Skip to content

Bug 1808118: Implemented operator log level controller#602

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
ricardomaraschini:bz-1808118-4
Sep 8, 2020
Merged

Bug 1808118: Implemented operator log level controller#602
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
ricardomaraschini:bz-1808118-4

Conversation

@ricardomaraschini
Copy link
Copy Markdown
Contributor

@ricardomaraschini ricardomaraschini commented Aug 31, 2020

Implemented controller to monitor and sync changes on Spec.OperatorLogLevel

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 31, 2020

@ricardomaraschini: This pull request references Bugzilla bug 1808118, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1808118: Implemented operator log level controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini ricardomaraschini mentioned this pull request Aug 31, 2020
Closed
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@ricardomaraschini
Copy link
Copy Markdown
Contributor Author

ricardomaraschini commented Aug 31, 2020

/retest

@ricardomaraschini
Copy link
Copy Markdown
Contributor Author

ricardomaraschini commented Aug 31, 2020

/assign @dmage

@ricardomaraschini
Copy link
Copy Markdown
Contributor Author

ricardomaraschini commented Sep 1, 2020

/retest

dmage
dmage reviewed Sep 8, 2020
View reviewed changes
Comment thread pkg/client/operatorclient.go Outdated
Comment thread pkg/operator/starter.go Outdated
Comment thread pkg/resource/podtemplatespec.go
case operatorapiv1.Debug, operatorapiv1.Trace, operatorapiv1.TraceAll:
return "debug"
default:
return "info"
Copy link
Copy Markdown
Contributor

@dmage dmage Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the telemetry, all customers (who send config.imageregistry) have logging=2. So I'd rather select the maximum of both, not minimum.

Copy link
Copy Markdown
Contributor Author

@ricardomaraschini ricardomaraschini Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this, PTAL. Basically, if Loglevel is set to operatorapiv1.Debug, operatorapiv1.Trace or operatorapiv1.TraceAll we set it to debug, otherwise (operatorapiv1.Normal) we fall back to Logging (but this time if it is zero we return "info" instead of "error" as before)

@ricardomaraschini
Implemented operator log level controller
fc8865c 
LogLevel controller keeps track of Operator log level specified through
Spec.OperatorLogLevel.
@dmage
Copy link
Copy Markdown
Contributor

dmage commented Sep 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dmage,ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad0f62d into openshift:master Sep 8, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 8, 2020

@ricardomaraschini: All pull requests linked via external trackers have merged:

Bugzilla bug 1808118 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1808118: Implemented operator log level controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@dmage dmage dmage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmage dmage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ricardomaraschini @openshift-ci-robot @dmage @openshift-merge-robot